-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 'auto' value in DD_PROFILING_ENABLED #7264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbachorik
force-pushed
the
jb/ssi_profiler_auto
branch
from
July 1, 2024 15:38
eae82da
to
8346505
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.37.0-SNAPSHOT~c3014c8cc3, baseline=1.37.0-SNAPSHOT~a9dde4fd66
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073301
Total [baseline] (8.571 s) : 0, 8570586
Agent [candidate] (1.066 s) : 0, 1066258
Total [candidate] (8.564 s) : 0, 8563627
section iast
Agent [baseline] (1.174 s) : 0, 1174359
Total [baseline] (8.994 s) : 0, 8993919
Agent [candidate] (1.184 s) : 0, 1184150
Total [candidate] (9.058 s) : 0, 9057724
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1172997
Total [baseline] (8.979 s) : 0, 8979381
Agent [candidate] (1.181 s) : 0, 1181103
Total [candidate] (8.972 s) : 0, 8971893
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1171501
Total [baseline] (8.997 s) : 0, 8997271
Agent [candidate] (1.175 s) : 0, 1174713
Total [candidate] (9.015 s) : 0, 9015047
gantt
title insecure-bank - break down per module: candidate=1.37.0-SNAPSHOT~c3014c8cc3, baseline=1.37.0-SNAPSHOT~a9dde4fd66
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.956 ms) : 0, 671956
BytebuddyAgent [candidate] (667.571 ms) : 0, 667571
GlobalTracer [baseline] (307.726 ms) : 0, 307726
GlobalTracer [candidate] (305.349 ms) : 0, 305349
AppSec [baseline] (50.646 ms) : 0, 50646
AppSec [candidate] (50.47 ms) : 0, 50470
Remote Config [baseline] (751.459 µs) : 0, 751
Remote Config [candidate] (716.586 µs) : 0, 717
Telemetry [baseline] (7.545 ms) : 0, 7545
Telemetry [candidate] (7.613 ms) : 0, 7613
section iast
BytebuddyAgent [baseline] (782.404 ms) : 0, 782404
BytebuddyAgent [candidate] (788.589 ms) : 0, 788589
GlobalTracer [baseline] (295.281 ms) : 0, 295281
GlobalTracer [candidate] (297.636 ms) : 0, 297636
AppSec [baseline] (47.537 ms) : 0, 47537
AppSec [candidate] (47.96 ms) : 0, 47960
Remote Config [baseline] (575.33 µs) : 0, 575
Remote Config [candidate] (562.169 µs) : 0, 562
Telemetry [baseline] (7.007 ms) : 0, 7007
Telemetry [candidate] (6.966 ms) : 0, 6966
IAST [baseline] (28.126 ms) : 0, 28126
IAST [candidate] (28.822 ms) : 0, 28822
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.344 ms) : 0, 780344
BytebuddyAgent [candidate] (786.377 ms) : 0, 786377
GlobalTracer [baseline] (295.402 ms) : 0, 295402
GlobalTracer [candidate] (296.852 ms) : 0, 296852
AppSec [baseline] (47.433 ms) : 0, 47433
AppSec [candidate] (47.842 ms) : 0, 47842
Remote Config [baseline] (610.759 µs) : 0, 611
Remote Config [candidate] (579.837 µs) : 0, 580
Telemetry [baseline] (7.716 ms) : 0, 7716
Telemetry [candidate] (6.956 ms) : 0, 6956
IAST [baseline] (28.075 ms) : 0, 28075
IAST [candidate] (28.876 ms) : 0, 28876
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.915 ms) : 0, 780915
BytebuddyAgent [candidate] (783.706 ms) : 0, 783706
GlobalTracer [baseline] (295.269 ms) : 0, 295269
GlobalTracer [candidate] (295.345 ms) : 0, 295345
AppSec [baseline] (47.258 ms) : 0, 47258
AppSec [candidate] (46.957 ms) : 0, 46957
Remote Config [baseline] (668.869 µs) : 0, 669
Remote Config [candidate] (648.997 µs) : 0, 649
Telemetry [baseline] (6.909 ms) : 0, 6909
Telemetry [candidate] (6.792 ms) : 0, 6792
IAST [baseline] (26.998 ms) : 0, 26998
IAST [candidate] (27.656 ms) : 0, 27656
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.37.0-SNAPSHOT~c3014c8cc3, baseline=1.37.0-SNAPSHOT~a9dde4fd66
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074469
Total [baseline] (10.401 s) : 0, 10401487
Agent [candidate] (1.065 s) : 0, 1065452
Total [candidate] (10.402 s) : 0, 10401954
section appsec
Agent [baseline] (1.196 s) : 0, 1195629
Total [baseline] (10.562 s) : 0, 10561587
Agent [candidate] (1.186 s) : 0, 1185851
Total [candidate] (10.567 s) : 0, 10567222
section iast
Agent [baseline] (1.174 s) : 0, 1174248
Total [baseline] (10.785 s) : 0, 10784876
Agent [candidate] (1.173 s) : 0, 1173447
Total [candidate] (10.789 s) : 0, 10788588
section profiling
Agent [baseline] (1.275 s) : 0, 1275039
Total [baseline] (10.714 s) : 0, 10713961
Agent [candidate] (1.271 s) : 0, 1270694
Total [candidate] (10.781 s) : 0, 10781309
gantt
title petclinic - break down per module: candidate=1.37.0-SNAPSHOT~c3014c8cc3, baseline=1.37.0-SNAPSHOT~a9dde4fd66
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.794 ms) : 0, 673794
BytebuddyAgent [candidate] (666.816 ms) : 0, 666816
GlobalTracer [baseline] (306.678 ms) : 0, 306678
GlobalTracer [candidate] (305.055 ms) : 0, 305055
AppSec [baseline] (50.731 ms) : 0, 50731
AppSec [candidate] (50.501 ms) : 0, 50501
Remote Config [baseline] (730.103 µs) : 0, 730
Remote Config [candidate] (699.656 µs) : 0, 700
Telemetry [baseline] (7.665 ms) : 0, 7665
Telemetry [candidate] (7.623 ms) : 0, 7623
section appsec
BytebuddyAgent [baseline] (684.476 ms) : 0, 684476
BytebuddyAgent [candidate] (678.281 ms) : 0, 678281
GlobalTracer [baseline] (301.526 ms) : 0, 301526
GlobalTracer [candidate] (299.191 ms) : 0, 299191
AppSec [baseline] (155.045 ms) : 0, 155045
AppSec [candidate] (154.406 ms) : 0, 154406
IAST [baseline] (21.82 ms) : 0, 21820
IAST [candidate] (20.481 ms) : 0, 20481
Remote Config [baseline] (637.181 µs) : 0, 637
Remote Config [candidate] (637.69 µs) : 0, 638
Telemetry [baseline] (8.087 ms) : 0, 8087
Telemetry [candidate] (8.369 ms) : 0, 8369
section iast
BytebuddyAgent [baseline] (782.537 ms) : 0, 782537
BytebuddyAgent [candidate] (780.673 ms) : 0, 780673
GlobalTracer [baseline] (295.811 ms) : 0, 295811
GlobalTracer [candidate] (295.196 ms) : 0, 295196
AppSec [baseline] (47.468 ms) : 0, 47468
AppSec [candidate] (47.451 ms) : 0, 47451
IAST [baseline] (25.784 ms) : 0, 25784
IAST [candidate] (28.986 ms) : 0, 28986
Remote Config [baseline] (577.268 µs) : 0, 577
Remote Config [candidate] (600.421 µs) : 0, 600
Telemetry [baseline] (8.631 ms) : 0, 8631
Telemetry [candidate] (7.014 ms) : 0, 7014
section profiling
BytebuddyAgent [baseline] (669.385 ms) : 0, 669385
BytebuddyAgent [candidate] (665.47 ms) : 0, 665470
GlobalTracer [baseline] (390.613 ms) : 0, 390613
GlobalTracer [candidate] (391.037 ms) : 0, 391037
AppSec [baseline] (52.306 ms) : 0, 52306
AppSec [candidate] (52.265 ms) : 0, 52265
Remote Config [baseline] (665.424 µs) : 0, 665
Remote Config [candidate] (686.201 µs) : 0, 686
Telemetry [baseline] (7.493 ms) : 0, 7493
Telemetry [candidate] (7.459 ms) : 0, 7459
ProfilingAgent [baseline] (96.796 ms) : 0, 96796
ProfilingAgent [candidate] (96.45 ms) : 0, 96450
Profiling [baseline] (96.82 ms) : 0, 96820
Profiling [candidate] (96.475 ms) : 0, 96475
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~c3014c8cc3, baseline=1.37.0-SNAPSHOT~a9dde4fd66
dateFormat X
axisFormat %s
section baseline
no_agent (370.877 µs) : 350, 392
. : milestone, 371,
iast (479.188 µs) : 458, 500
. : milestone, 479,
iast_FULL (547.606 µs) : 526, 569
. : milestone, 548,
iast_GLOBAL (503.426 µs) : 483, 524
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (479.427 µs) : 458, 501
. : milestone, 479,
iast_INACTIVE (451.354 µs) : 430, 473
. : milestone, 451,
iast_TELEMETRY_OFF (472.028 µs) : 450, 494
. : milestone, 472,
tracing (441.963 µs) : 421, 463
. : milestone, 442,
section candidate
no_agent (365.116 µs) : 345, 386
. : milestone, 365,
iast (485.162 µs) : 464, 507
. : milestone, 485,
iast_FULL (544.665 µs) : 524, 566
. : milestone, 545,
iast_GLOBAL (501.227 µs) : 480, 522
. : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (482.891 µs) : 462, 504
. : milestone, 483,
iast_INACTIVE (455.372 µs) : 434, 477
. : milestone, 455,
iast_TELEMETRY_OFF (465.264 µs) : 444, 486
. : milestone, 465,
tracing (438.648 µs) : 418, 459
. : milestone, 439,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~c3014c8cc3, baseline=1.37.0-SNAPSHOT~a9dde4fd66
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1361
. : milestone, 1341,
appsec (1.707 ms) : 1683, 1731
. : milestone, 1707,
appsec_no_iast (1.734 ms) : 1709, 1758
. : milestone, 1734,
iast (1.468 ms) : 1445, 1492
. : milestone, 1468,
profiling (1.556 ms) : 1523, 1590
. : milestone, 1556,
tracing (1.465 ms) : 1440, 1489
. : milestone, 1465,
section candidate
no_agent (1.346 ms) : 1327, 1366
. : milestone, 1346,
appsec (1.732 ms) : 1708, 1756
. : milestone, 1732,
appsec_no_iast (1.73 ms) : 1706, 1754
. : milestone, 1730,
iast (1.49 ms) : 1467, 1513
. : milestone, 1490,
profiling (1.498 ms) : 1473, 1524
. : milestone, 1498,
tracing (1.473 ms) : 1448, 1499
. : milestone, 1473,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~c3014c8cc3, baseline=1.37.0-SNAPSHOT~a9dde4fd66
dateFormat X
axisFormat %s
section baseline
no_agent (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
appsec (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
iast (18.764 s) : 18764000, 18764000
. : milestone, 18764000,
iast_GLOBAL (17.857 s) : 17857000, 17857000
. : milestone, 17857000,
profiling (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
tracing (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
section candidate
no_agent (15.156 s) : 15156000, 15156000
. : milestone, 15156000,
appsec (15.319 s) : 15319000, 15319000
. : milestone, 15319000,
iast (18.444 s) : 18444000, 18444000
. : milestone, 18444000,
iast_GLOBAL (17.777 s) : 17777000, 17777000
. : milestone, 17777000,
profiling (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
tracing (15.203 s) : 15203000, 15203000
. : milestone, 15203000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~c3014c8cc3, baseline=1.37.0-SNAPSHOT~a9dde4fd66
dateFormat X
axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.216 ms) : 2180, 2251
. : milestone, 2216,
iast (1.975 ms) : 1932, 2017
. : milestone, 1975,
iast_GLOBAL (2.02 ms) : 1977, 2064
. : milestone, 2020,
profiling (1.854 ms) : 1819, 1888
. : milestone, 1854,
tracing (1.855 ms) : 1820, 1889
. : milestone, 1855,
section candidate
no_agent (1.458 ms) : 1446, 1469
. : milestone, 1458,
appsec (2.227 ms) : 2191, 2262
. : milestone, 2227,
iast (1.973 ms) : 1931, 2016
. : milestone, 1973,
iast_GLOBAL (2.005 ms) : 1962, 2048
. : milestone, 2005,
profiling (1.856 ms) : 1821, 1892
. : milestone, 1856,
tracing (1.835 ms) : 1801, 1868
. : milestone, 1835,
|
jbachorik
force-pushed
the
jb/ssi_profiler_auto
branch
from
July 2, 2024 09:41
8346505
to
f651a24
Compare
jbachorik
force-pushed
the
jb/ssi_profiler_auto
branch
from
July 2, 2024 10:09
f651a24
to
c3014c8
Compare
richardstartin
approved these changes
Jul 2, 2024
PerfectSlayer
changed the title
PROF-10082: Add support for 'auto' value in DD_PROFILING_ENABLED
Add support for 'auto' value in DD_PROFILING_ENABLED
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds a support for a new state
auto
forprofiling.enabled
config option.Motivation
For SSI (Single Step Instrumentation) a new state for the profiler enablement was added - 'auto'.
The enablement used to be a boolean flag, so the only supported values were
true
andfalse
, regardless of the case.Therefore, a specific support for
auto
must be added.Additional Notes
Since the 'auto' activation presumes a 'testing' period before enabling profiling (eg. an app must have been running for 10-20 seconds so we don't activate for something like command line utilities) a part of the 'auto' enablement is making sure that the user defined values for the initial delay and 'force-start-first' flag are ignored.
Jira ticket: PROF-10082